[llvm-commits] [llvm] r172296 - /llvm/trunk/utils/buildit/build_llvm

[Bob Wilson]

Author: bwilson
Date: Fri Jan 11 20:31:42 2013
New Revision: 172296

URL: http://llvm.org/viewvc/llvm-project?rev=172296&view=rev
Log:
Fix quoting problems from my previous change. <rdar://problem/13001651>

I give up trying to get all of the settings into COMMON_MAKEFLAGS, so just
do the easy thing and repeat the ones with interesting quoting issues
in each make command.

Modified:
    llvm/trunk/utils/buildit/build_llvm

Modified: llvm/trunk/utils/buildit/build_llvm
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/buildit/build_llvm?rev=172296&r1=172295&r2=172296&view=diff
==============================================================================
--- llvm/trunk/utils/buildit/build_llvm (original)
+++ llvm/trunk/utils/buildit/build_llvm Fri Jan 11 20:31:42 2013
@@ -88,7 +88,6 @@
 else
     LLVM_VERSION="$LLVM_SUBMIT_VERSION-$LLVM_SUBMIT_SUBVERSION"
 fi
-LLVM_VERSION_INFO="'\" Apple Build #$LLVM_VERSION\"'"
 
 # Figure out how many make processes to run.
 SYSCTL=`sysctl -n hw.activecpu`
@@ -106,7 +105,16 @@
   --enable-optimized=$LLVM_OPTIMIZED \
   --disable-bindings"
 
-COMMON_MAKEFLAGS=$JOBS_FLAG $OPTIMIZE_OPTS UNIVERSAL=1 UNIVERSAL_ARCH="$HOSTS" UNIVERSAL_SDK_PATH=$SDKROOT NO_RUNTIME_LIBS=1 DISABLE_EDIS=1 REQUIRES_RTTI=1 DEBUG_SYMBOLS=1 LLVM_SUBMIT_VERSION=$LLVM_SUBMIT_VERSION LLVM_SUBMIT_SUBVERSION=$LLVM_SUBMIT_SUBVERSION CXXFLAGS=-DLLVM_VERSION_INFO="$LLVM_VERSION_INFO" VERBOSE=1
+COMMON_MAKEFLAGS="\
+  UNIVERSAL=1 \
+  UNIVERSAL_SDK_PATH=$SDKROOT \
+  NO_RUNTIME_LIBS=1 \
+  DISABLE_EDIS=1 \
+  REQUIRES_RTTI=1 \
+  DEBUG_SYMBOLS=1 \
+  LLVM_SUBMIT_VERSION=$LLVM_SUBMIT_VERSION \
+  LLVM_SUBMIT_SUBVERSION=$LLVM_SUBMIT_SUBVERSION \
+  VERBOSE=1"
 
 # Build the LLVM tree universal.
 mkdir -p $DIR/obj-llvm || exit 1
@@ -146,7 +154,8 @@
     --program-prefix="" \
     || exit 1
 
-  make $COMMON_MAKEFLAGS SDKROOT=
+  make $JOBS_FLAG $COMMON_MAKEFLAGS SDKROOT= UNIVERSAL_ARCH="$HOSTS" \
+    CXXFLAGS="-DLLVM_VERSION_INFO='\" Apple Build #$LLVM_VERSION\"'"
   if [ $? != 0 ] ; then
     echo "error: LLVM 'make' failed!"
     exit 1
@@ -174,7 +183,8 @@
     CPPFLAGS="$CPPFLAGS" \
     || exit 1
 
-  make $COMMON_MAKEFLAGS
+  make $JOBS_FLAG $COMMON_MAKEFLAGS UNIVERSAL_ARCH="$HOSTS" \
+    CXXFLAGS="-DLLVM_VERSION_INFO='\" Apple Build #$LLVM_VERSION\"'"
   if [ $? != 0 ] ; then
     echo "error: LLVM 'make' failed!"
     exit 1
@@ -193,7 +203,7 @@
 cd $DIR/obj-llvm || exit 1
 
 # Install the tree into the destination directory.
-make $COMMON_MAKEFLAGS install
+make $JOBS_FLAG $COMMON_MAKEFLAGS UNIVERSAL_ARCH="$HOSTS" install
 if ! test $? == 0 ; then
     echo "error: LLVM 'make install' failed!"
     exit 1