[llvm-commits] [PATCH] InstCombineWorkList: s/Add/AddInst/g

NAKAMURA Takumi geek4civic at gmail.com
Fri Jan 11 17:32:11 PST 2013


Motivation -- I am using DEBUG prettyprinting in my local branch, like;

  void AddInst_(Instruction *I) {
    ...
  }
#define AddInst(I) AddInst_(((errs() << __func__ << ":" << __LINE__ << " [IC] "), (I)))

Then, an easy mame "Add" clashes other methods somewhere in LLVM. It could be avoided to rename InstCombineWorkList::Add().

For consistency, I took "AddInst" instead of "Add".

http://llvm-reviews.chandlerc.com/D292

Files:
  llvm/lib/Transforms/InstCombine/InstCombine.h
  llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
  llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
  llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
  llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
  llvm/lib/Transforms/InstCombine/InstCombineWorklist.h
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D292.1.patch
Type: text/x-patch
Size: 10179 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130111/5fc2dd13/attachment.bin>


More information about the llvm-commits mailing list