[llvm-commits] Add hexagon flags in ELF.h

Shankar Easwaran shankare at codeaurora.org
Wed Jan 9 08:15:33 PST 2013


Makes sense, Thanks for the review. I will move that to the appropriate 
enumeration and commit.

Thanks

Shankar Easwaran

On 1/9/2013 9:49 AM, Tim Northover wrote:
>> Adding Hexagon specific flags in ELF.h.
> It looks like other targets put the processor-specific flags in the
> same enum as the generic ones. Wouldn't it be better to follow that
> style?
>
> I'm also a little unconvinced by the "~SHF_MASKPROC + 1".  If there
> were ever a host where int is larger than 32-bits I think it would go
> horribly wrong. Current targets (well, x86) just hard-code
> 0x10000000.
>
> Tim.
>
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list