[llvm-commits] Add hexagon flags in ELF.h

Tim Northover t.p.northover at gmail.com
Wed Jan 9 07:49:57 PST 2013


> Adding Hexagon specific flags in ELF.h.

It looks like other targets put the processor-specific flags in the
same enum as the generic ones. Wouldn't it be better to follow that
style?

I'm also a little unconvinced by the "~SHF_MASKPROC + 1".  If there
were ever a host where int is larger than 32-bits I think it would go
horribly wrong. Current targets (well, x86) just hard-code
0x10000000.

Tim.



More information about the llvm-commits mailing list