[llvm-commits] [llvm] r162230 - in /llvm/trunk: lib/CodeGen/MachineVerifier.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp test/CodeGen/ARM/constants.ll

[Dmitri Gribenko]

On Wed, Dec 19, 2012 at 11:02 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>
> On Dec 19, 2012, at 11:01 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>
>> On Tue, Aug 21, 2012 at 12:39 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>>>       ++MBBI;
>>>       if (MBBI == MF->end()) {
>>>         report("MBB conditionally falls through out of function!", MBB);
>>> -      } if (MBB->succ_size() != 2) {
>>> +      } if (MBB->succ_size() == 1) {
>>
>> Hello Jakob,
>>
>> Sorry to comment on an old commit, but '} if (...' looks suspicious --
>> 'else' is probably missing.  I have just fixed two bugs of this kind
>> in Clang, found by grep '} if'.
>
> Yikes, that does indeed look like a missing else.
>
> Please go ahead and fix it.

OK to commit without a testcase?

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/