[llvm-commits] [llvm] r162230 - in /llvm/trunk: lib/CodeGen/MachineVerifier.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp test/CodeGen/ARM/constants.ll

[Jakob Stoklund Olesen]

On Dec 19, 2012, at 11:01 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Tue, Aug 21, 2012 at 12:39 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>>       ++MBBI;
>>       if (MBBI == MF->end()) {
>>         report("MBB conditionally falls through out of function!", MBB);
>> -      } if (MBB->succ_size() != 2) {
>> +      } if (MBB->succ_size() == 1) {
> 
> Hello Jakob,
> 
> Sorry to comment on an old commit, but '} if (...' looks suspicious --
> 'else' is probably missing.  I have just fixed two bugs of this kind
> in Clang, found by grep '} if'.

Yikes, that does indeed look like a missing else.

Please go ahead and fix it.

Thanks,

/jakob