[llvm-commits] [PATCH] tsan: add mutexsets to reports

Kostya Serebryany kcc at google.com
Thu Dec 6 03:48:38 PST 2012


  Looks great!


================
Comment at: rtl/tsan_rtl_report.cc:291
@@ -250,3 +290,3 @@
 
-void RestoreStack(int tid, const u64 epoch, StackTrace *stk) {
+void RestoreStack(int tid, const u64 epoch, StackTrace *stk, MutexSet *mset) {
   ThreadContext *tctx = CTX()->threads[tid];
----------------
This part is non-trivial and important. 
Could you please add a comment describing the whole thing?


http://llvm-reviews.chandlerc.com/D182



More information about the llvm-commits mailing list