[llvm-commits] [PATCH] tsan: add mutexsets to reports

[Dmitry Vyukov]

================
Comment at: rtl/tsan_mutexset.h:22
@@ +21,3 @@
+ public:
+  static const uptr kMaxSize = 64;
+  struct Desc {
----------------
Kostya Serebryany wrote:
> Maybe a template parameter?
That will pull everything into the header file w/o any benefit.
Let's do it if there is a need.

================
Comment at: rtl/tsan_rtl_report.cc:153
@@ +152,3 @@
+    uptr addr = SyncVar::SplitId(d.id, &uid);
+    SyncVar *s = ctx_->synctab.GetAndLock(0, 0, addr, false, false);
+    if (s && s->CheckId(uid)) {
----------------
Kostya Serebryany wrote:
> This part looks tricky. Comments?
Done.

================
Comment at: rtl/tsan_mutexset.h:11
@@ +10,3 @@
+// This file is a part of ThreadSanitizer (TSan), a race detector.
+//
+//===----------------------------------------------------------------------===//
----------------
Kostya Serebryany wrote:
> Comments, please!! 
Done.


http://llvm-reviews.chandlerc.com/D182