[llvm-commits] [llvm] r169117 - /llvm/trunk/lib/Target/Hexagon/HexagonOperands.td

[Craig Topper]

This code also has a lot of 'else' after a block ending in 'return'. This
should be avoided per coding standards.

On Mon, Dec 3, 2012 at 9:05 AM, Jyotsna Verma <jverma at codeaurora.org> wrote:

> Let me give it a thought. There is a lot of common functionality across
> these predicates. It would be nice to have that factored out somehow. At
> this point, I'm going to open a bug and revisit it later.
>
> Thanks,
> Jyotsna
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by
> The Linux Foundation
>
>
> > -----Original Message-----
> > From: Sean Silva [mailto:silvas at purdue.edu]
> > Sent: Monday, December 03, 2012 1:26 AM
> > To: Jyotsna Verma
> > Cc: llvm-commits at cs.uiuc.edu
> > Subject: Re: [llvm-commits] [llvm] r169117 -
> > /llvm/trunk/lib/Target/Hexagon/HexagonOperands.td
> >
> > > Sean, what exactly are you suggesting?
> >
> > I'm not intimately familiar with this part of LLVM, so I don't have any
> concrete
> > suggestions, but is there not some way to have all these patterns inherit
> > from a common base that encapsulates the subtarget check?
> >
> > -- Sean Silva
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121203/7d911d78/attachment.html>