[llvm-commits] [llvm] r169117 - /llvm/trunk/lib/Target/Hexagon/HexagonOperands.td

[Jyotsna Verma]

Let me give it a thought. There is a lot of common functionality across
these predicates. It would be nice to have that factored out somehow. At
this point, I'm going to open a bug and revisit it later.

Thanks,
Jyotsna
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


> -----Original Message-----
> From: Sean Silva [mailto:silvas at purdue.edu]
> Sent: Monday, December 03, 2012 1:26 AM
> To: Jyotsna Verma
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [llvm] r169117 -
> /llvm/trunk/lib/Target/Hexagon/HexagonOperands.td
> 
> > Sean, what exactly are you suggesting?
> 
> I'm not intimately familiar with this part of LLVM, so I don't have any
concrete
> suggestions, but is there not some way to have all these patterns inherit
> from a common base that encapsulates the subtarget check?
> 
> -- Sean Silva