[llvm-commits] [llvm] r168181 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCompares.cpp test/Transforms/InstCombine/icmp.ll

[NAKAMURA Takumi]

>>>  I do no think merging partial patches into the release branch
>>> should be the way we deal with issues unless there is no other
>>> way the to fix a problem.
>>
>> I proposed minimal fix. r168196 is "similar simplification without any
>> dependence each other."
>> To be more consistent, I might suggest "both r168186 and r168196".
>> They could be applied cleanly on the release_32.
>
>
> Sounds good to me, however the release process requires approval from
> the code owner so your first point of contact should be the code
> owner or owners of the r168186 and r168196.

Duncan,

I propose as below, two options;

1) r168186 and r168196

2) InstCombineCompares.cpp in r168196 (partial)

Could you please approve either to the release_32?
(Or could you delegate it to other responsible person?)
I am sure I can propose to let the tree free from warnings (with clang).

...Takumi