[llvm-commits] [llvm] r168181 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCompares.cpp test/Transforms/InstCombine/icmp.ll

[Pawel Wodnicki]

Takumi,

> 2012/11/23 Pawel Wodnicki <pawel at 32bitmicro.com>:
>>  As for your original request, from the release process perspective:
>>
>>  I should be getting and processing requests approved
>> by code owners only :)
> 
> I am sorry that I asked you directly. I understand it would not be my business.


I do not mind at all people contacting me! I was merely pointing out
current release process which is intended to streamline the
communication I guess.


> 
> Instead, I shall let you know if you picked up incomplete commits to
> break the release build.
> I am certain to be one of testers (aka watchers) on the release.


Your buildbot at http://bb.pgr.jp is a fantastic resource
which I check daily!


> (Did you know you didn't apply clang r168297 cleanly and it caused
> failure in clang/test/Driver/pic.c?)


I do know that pic.c is causing problems, actually entire r168297
patch is problematic for various reasons.


> 
>>  I do no think merging partial patches into the release branch
>> should be the way we deal with issues unless there is no other
>> way the to fix a problem.
> 
> I proposed minimal fix. r168196 is "similar simplification without any
> dependence each other."
> To be more consistent, I might suggest "both r168186 and r168196".
> They could be applied cleanly on the release_32.


Sounds good to me, however the release process requires approval from
the code owner so your first point of contact should be the code
owner or owners of the r168186 and r168196.


> 
> 
> ...Takumi
> 
> 

I hope I have cleared some of the issues which seem to be
"lost in translation" so to speak.

If not then all I can say is sumimasen!

Pawel