[llvm-commits] [PATCH] Copy clang/Driver/<Option parsing stuff> to llvm.

Daniel Dunbar daniel at zuster.org
Mon Nov 5 16:31:49 PST 2012


I'll give more comments later, but I definitely think it should get its own
library, Support/Arg doesn't make sense to me.

 - Daniel


On Mon, Nov 5, 2012 at 4:21 PM, Michael Spencer <bigcheesegs at gmail.com>wrote:

> Hi ddunbar,
>
> This patch copies the option parsing parts of the clang driver to llvm. It
> also adds unit tests that cover the basics of the API.
>
> ArgList::getLastArgIntValue was removed because it needs clang
> diagnostics. This function will be moved to clang.
>
> One thing I'm not sure about with this patch is adding this to the Support
> library. "llvm/Support/Arg.h" seems odd. Is this fine in Support? Or should
> it get it's own Library? Also this makes unittests/Support depend on
> TableGen.
>
>
> http://llvm-reviews.chandlerc.com/D102
>
> Files:
>   include/llvm/Support/Arg.h
>   include/llvm/Support/ArgList.h
>   include/llvm/Support/OptParser.td
>   include/llvm/Support/OptSpecifier.h
>   include/llvm/Support/OptTable.h
>   include/llvm/Support/Option.h
>   lib/Support/Arg.cpp
>   lib/Support/ArgList.cpp
>   lib/Support/CMakeLists.txt
>   lib/Support/OptTable.cpp
>   lib/Support/Option.cpp
>   unittests/Support/CMakeLists.txt
>   unittests/Support/OptionParsingTest.cpp
>   unittests/Support/Opts.td
>   utils/TableGen/CMakeLists.txt
>   utils/TableGen/OptParserEmitter.cpp
>   utils/TableGen/TableGen.cpp
>   utils/TableGen/TableGenBackends.h
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121105/c42bb281/attachment.html>


More information about the llvm-commits mailing list