I'll give more comments later, but I definitely think it should get its own library, Support/Arg doesn't make sense to me.<div><br></div><div> - Daniel</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Nov 5, 2012 at 4:21 PM, Michael Spencer <span dir="ltr"><<a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi ddunbar,<br>
<br>
This patch copies the option parsing parts of the clang driver to llvm. It also adds unit tests that cover the basics of the API.<br>
<br>
ArgList::getLastArgIntValue was removed because it needs clang diagnostics. This function will be moved to clang.<br>
<br>
One thing I'm not sure about with this patch is adding this to the Support library. "llvm/Support/Arg.h" seems odd. Is this fine in Support? Or should it get it's own Library? Also this makes unittests/Support depend on TableGen.<br>

<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D102" target="_blank">http://llvm-reviews.chandlerc.com/D102</a><br>
<br>
Files:<br>
  include/llvm/Support/Arg.h<br>
  include/llvm/Support/ArgList.h<br>
  include/llvm/Support/OptParser.td<br>
  include/llvm/Support/OptSpecifier.h<br>
  include/llvm/Support/OptTable.h<br>
  include/llvm/Support/Option.h<br>
  lib/Support/Arg.cpp<br>
  lib/Support/ArgList.cpp<br>
  lib/Support/CMakeLists.txt<br>
  lib/Support/OptTable.cpp<br>
  lib/Support/Option.cpp<br>
  unittests/Support/CMakeLists.txt<br>
  unittests/Support/OptionParsingTest.cpp<br>
  unittests/Support/Opts.td<br>
  utils/TableGen/CMakeLists.txt<br>
  utils/TableGen/OptParserEmitter.cpp<br>
  utils/TableGen/TableGen.cpp<br>
  utils/TableGen/TableGenBackends.h<br>
</blockquote></div><br></div>