[llvm-commits] [llvm] r166854 - in /llvm/trunk: lib/Target/ARM/ARMISelLowering.cpp test/CodeGen/ARM/call-noret-forsize.ll

[Quentin Colombet]

Author: qcolombet
Date: Fri Oct 26 20:10:17 2012
New Revision: 166854

URL: http://llvm.org/viewvc/llvm-project?rev=166854&view=rev
Log:
[code size][ARM] Emit regular call instructions instead of the move, branch sequence

Added:
    llvm/trunk/test/CodeGen/ARM/call-noret-forsize.ll
Modified:
    llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=166854&r1=166853&r2=166854&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Fri Oct 26 20:10:17 2012
@@ -1594,11 +1594,15 @@
 
   // FIXME: handle tail calls differently.
   unsigned CallOpc;
+  bool HasForceSizeAttr = MF.getFunction()->getFnAttributes().
+                          hasAttribute(Attributes::ForceSizeOpt);
   if (Subtarget->isThumb()) {
     if ((!isDirect || isARMFunc) && !Subtarget->hasV5TOps())
       CallOpc = ARMISD::CALL_NOLINK;
     else if (doesNotRet && isDirect && !isARMFunc &&
-             Subtarget->hasRAS() && !Subtarget->isThumb1Only())
+             Subtarget->hasRAS() && !Subtarget->isThumb1Only() &&
+	     // Emit regular call when code size is the priority
+	     !HasForceSizeAttr)
       // "mov lr, pc; b _foo" to avoid confusing the RSP
       CallOpc = ARMISD::CALL_NOLINK;
     else
@@ -1606,7 +1610,9 @@
   } else {
     if (!isDirect && !Subtarget->hasV5TOps()) {
       CallOpc = ARMISD::CALL_NOLINK;
-    } else if (doesNotRet && isDirect && Subtarget->hasRAS())
+    } else if (doesNotRet && isDirect && Subtarget->hasRAS() &&
+	       // Emit regular call when code size is the priority
+	       !HasForceSizeAttr)
       // "mov lr, pc; b _foo" to avoid confusing the RSP
       CallOpc = ARMISD::CALL_NOLINK;
     else

Added: llvm/trunk/test/CodeGen/ARM/call-noret-forsize.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/call-noret-forsize.ll?rev=166854&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/call-noret-forsize.ll (added)
+++ llvm/trunk/test/CodeGen/ARM/call-noret-forsize.ll Fri Oct 26 20:10:17 2012
@@ -0,0 +1,34 @@
+; RUN: llc < %s -mtriple=armv7-apple-ios -mcpu=cortex-a8   | FileCheck %s -check-prefix=ARM
+; RUN: llc < %s -mtriple=armv7-apple-ios -mcpu=swift       | FileCheck %s -check-prefix=SWIFT
+; RUN: llc < %s -mtriple=thumbv7-apple-ios -mcpu=cortex-a8 | FileCheck %s -check-prefix=T2
+; rdar://12348580
+
+define void @t1() noreturn forcesizeopt nounwind ssp {
+entry:
+; ARM: t1:
+; ARM: bl _bar
+
+; SWIFT: t1:
+; SWIFT: bl _bar
+
+; T2: t1:
+; T2: blx _bar
+  tail call void @bar() noreturn nounwind
+  unreachable
+}
+
+define void @t2() noreturn forcesizeopt nounwind ssp {
+entry:
+; ARM: t2:
+; ARM: bl _t1
+
+; SWIFT: t2:
+; SWIFT: bl _t1
+
+; T2: t2:
+; T2: bl _t1
+  tail call void @t1() noreturn nounwind
+  unreachable
+}
+
+declare void @bar() noreturn