[llvm-commits] [PATCH] PowerPC: More support for Altivec compare operations

[Will Schmidt]

On Wed, 2012-10-24 at 16:48 -0200, Adhemerval Zanella wrote:
> Will,
> 
> The llvm_unreachable (...) is a define to llvm_unreachable_internal (lib/Support/ErrorHandling.cpp) 
> and it does not accepts a vararg as argument. It means to construct a more elaborate errors message
> I'll need to code its construction. And since it is something wrong with the compiler itself and
> one will have to attach a debugger to check what it is wrong, I'm not compelling to add these kind 
> of logic.
> 
> > I see six "Invalid vector type with conditional code" string within
> > getVCMPInst().   Can these be updated to indicate which case we are in?
> > i.e. "Invalid vector type with conditional code (ISD::SETUNE) " 
> >
> 


I'm suggesting changing the base string from "Invalid vector type with
conditional code" to "Invalid vector type with conditional code
(ISD::SETUNE)".  No varargs necessary for that. 

It makes the copy/paste bits a bit more involved, but is the sort of
thing that would be helpful as I/we try to figure out what/where in the
code we are when we are hitting those messages.

Thanks, 
-Will