[llvm-commits] [PATCH] PowerPC: More support for Altivec compare operations

[Villmow, Micah]

In getVCMPInst, can you put " llvm_unreachable("Invalid vector type with conditional code");" at the end of the function and just have the switch statements break out instead of duplicating this multiple times.
Also can you turn switches with only a single case into a if check.


In SelectSetCC, can you factor the common code out of the switch statements.
> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Adhemerval Zanella
> Sent: Wednesday, October 24, 2012 7:50 AM
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm-commits] [PATCH] PowerPC: More support for Altivec
> compare operations
> 
> My previous patch for altivec compare support was incomplete, it didn't
> handle the other operators (!=, <, >, etc.). This patch add a better
> and more complete support for comparisons for altivec supported types
> (v16i8, v8i16, v4i32, and v4f32).
> 
> The testcase also covers all the supported comparison operators for the
> altivec types.
> 
> Any tips, suggestions, comments?