[llvm-commits] [llvm] r165506 - in /llvm/trunk/lib/Target/Mips: AsmParser/MipsAsmParser.cpp Mips64InstrInfo.td

[Carter, Jack]

Yes, we at Mips have been actively adding assembler patches and patches need to have test cases with the exception to patches in response to a previous patch that already had the test case.

It is a bit odd that this patch was not submitted for review.

Jack

>
> <llvm-source-dir>/test/MC/Mips

> > Theoretically, there should be near exhaustive tests for the instruction encodings and the > assembler parsing there that gets built up as the assembler support gets added to the target. If > that's not been the case so far, I strongly recommend that those involved in the assembler fix that. > Those tests are extremely valuable whenever instruction patterns get refactored.

> -Jim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121010/9122de82/attachment.html>