<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;"><font size="2"><span style="font-size:10pt;">Yes, we at Mips have been actively adding assembler patches and patches need to have test cases with the exception to patches in response
to a previous patch that already had the test case.<br>
<br>
It is a bit odd that this patch was not submitted for review.<br>
<br>
Jack<br>
<br>
> <br>
</span></font><font size="2"><span style="font-size:10pt;"><font size="2"><span style="font-size:10pt;">>
</span></font><llvm-source-dir>/test/MC/Mips<br>
</span></font><br>
<font size="2"><span style="font-size:10pt;">> </span></font><font size="2"><span style="font-size:10pt;"><font size="2"><span style="font-size:10pt;">>
</span></font>Theoretically, there should be near exhaustive tests for the instruction encodings and the
</span></font><font size="2"><span style="font-size:10pt;"><font size="2"><span style="font-size:10pt;">>
</span></font>assembler parsing there that gets built up as the assembler support gets added to the target. If
</span></font><font size="2"><span style="font-size:10pt;"><font size="2"><span style="font-size:10pt;">>
</span></font>that's not been the case so far, I strongly recommend that those involved in the assembler fix that.
</span></font><font size="2"><span style="font-size:10pt;"><font size="2"><span style="font-size:10pt;">>
</span></font>Those tests are extremely valuable whenever instruction patterns get refactored.<br>
<br>
</span></font><font size="2"><span style="font-size:10pt;"><font size="2"><span style="font-size:10pt;">>
</span></font>-Jim<br>
</span></font></div>
</body>
</html>