[llvm-commits] [ARM] Scheduler FixedFrame object vs byval formal parameters

[Manman Ren]

On Oct 5, 2012, at 2:59 AM, Stepan Dyatkovskiy <stpworld at narod.ru> wrote:

> Thanks. The idea looks fine. But r164553 assumes that size of Function's arguments set is equal to size of InputArgs set:
> "for (unsigned ArgNo = 0, e = Ins.size(); ArgNo != e; ++ArgNo, ++FuncArg) {"
> 
> But seems that it not always right. In SelectionDAGISel::LowerArguments we can see that Function argument be a set of multiple VTs, in that case multiple InputArg flags will be created for single argument. Try test your commit for complex params (structures or arrays).
I agree with you here. A function argument can be expanded to a set of VTs, and each VT can be further partitioned with TLI.getNumRegisters.

> 
> Perhaps, we can provide InputArg type with some info about Function's argument and offset?
I am okay with this approach, perhaps an index of the original function argument.

Thanks,
Manman

> 
> -Stepan.
> 
> Sergei Larin wrote:
>> Stepan,
>> 
>>   ...also see r164553.
>> 
>