[llvm-commits] [ARM] Scheduler FixedFrame object vs byval formal parameters

Stepan Dyatkovskiy stpworld at narod.ru
Fri Oct 5 02:59:09 PDT 2012


Thanks. The idea looks fine. But r164553 assumes that size of Function's 
arguments set is equal to size of InputArgs set:
"for (unsigned ArgNo = 0, e = Ins.size(); ArgNo != e; ++ArgNo, ++FuncArg) {"

But seems that it not always right. In SelectionDAGISel::LowerArguments 
we can see that Function argument be a set of multiple VTs, in that case 
multiple InputArg flags will be created for single argument. Try test 
your commit for complex params (structures or arrays).

Perhaps, we can provide InputArg type with some info about Function's 
argument and offset?

-Stepan.

Sergei Larin wrote:
> Stepan,
>
>    ...also see r164553.
>




More information about the llvm-commits mailing list