[llvm-commits] Provide interface in TargetLowering to control jump table.

Jim Grosbach grosbach at apple.com
Mon Sep 24 12:47:52 PDT 2012


I don't have any conceptual problem with the patch (seems like a good idea), but the naming could use a bit of cleaning up. Specifically, see: http://llvm.org/docs/CodingStandards.html#the-low-level-issues

-Jim

On Sep 24, 2012, at 12:43 PM, Sebastian Pop <spop at codeaurora.org> wrote:

> Ron Lieberman wrote:
>> Please review the attached patch which:
>> 
>> Provide interface in TargetLowering to control jump table
>> 
>> cutover for switches.
>> 
>> 
>> 
>>    cutoverJumpTables() defaults to 4.
>> 
>>    Default is set to 5 for hexagon target.
>> 
> 
> This change looks good to me.  Let's wait for some more comments before we
> submit your patch.
> 
> Thanks,
> Sebastian
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120924/e843720f/attachment.html>


More information about the llvm-commits mailing list