<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I don't have any conceptual problem with the patch (seems like a good idea), but the naming could use a bit of cleaning up. Specifically, see: <a href="http://llvm.org/docs/CodingStandards.html#the-low-level-issues">http://llvm.org/docs/CodingStandards.html#the-low-level-issues</a><div><br></div><div>-Jim</div><div><br><div><div>On Sep 24, 2012, at 12:43 PM, Sebastian Pop <<a href="mailto:spop@codeaurora.org">spop@codeaurora.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Ron Lieberman wrote:<br><blockquote type="cite">Please review the attached patch which:<br><br>Provide interface in TargetLowering to control jump table<br><br>cutover for switches.<br><br><br><br> cutoverJumpTables() defaults to 4.<br><br> Default is set to 5 for hexagon target.<br><br></blockquote><br>This change looks good to me. Let's wait for some more comments before we<br>submit your patch.<br><br>Thanks,<br>Sebastian<br>-- <br>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation<br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>