[llvm-commits] [llvm] r164173 - in /llvm/trunk: include/llvm/Transforms/Utils/IntegerDivision.h lib/Transforms/Utils/CMakeLists.txt lib/Transforms/Utils/IntegerDivision.cpp

[Sean Silva]

Could you elaborate on this old-style vs new-style thing? Also, a bit
more explanation in the coding standards is probably in order ("older
code uses names like ... but the expectation for new code (except
where incongruous) is ...".

--Sean Silva

On Wed, Sep 19, 2012 at 1:43 PM, Andrew Trick <atrick at apple.com> wrote:
> On Sep 19, 2012, at 9:33 AM, Michael Ilseman <milseman at apple.com> wrote:
>
> About the naming conventions, I'm a little confused. The coding standard
> says that function names should begin lower case, but all the static
> function examples shown begin in upper case. Should those really be lower
> case instead, or are static functions to be upper case? Are there other
> violations of the naming convention here?
>
>
> Yes, there are plenty of violations. I try to use the new style unless it's
> too incongruous with the existing code. If the percentage of new code
> reaches some threshold, then I do a bulk rename of the old functions.
> -Andy
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>