[llvm-commits] [llvm] r164173 - in /llvm/trunk: include/llvm/Transforms/Utils/IntegerDivision.h lib/Transforms/Utils/CMakeLists.txt lib/Transforms/Utils/IntegerDivision.cpp

[Jim Grosbach]

On Sep 19, 2012, at 10:43 AM, Andrew Trick <atrick at apple.com> wrote:

> On Sep 19, 2012, at 9:33 AM, Michael Ilseman <milseman at apple.com> wrote:
>> About the naming conventions, I'm a little confused. The coding standard says that function names should begin lower case, but all the static function examples shown begin in upper case. Should those really be lower case instead, or are static functions to be upper case? Are there other violations of the naming convention here?
> 
> Yes, there are plenty of violations. I try to use the new style unless it's too incongruous with the existing code. If the percentage of new code reaches some threshold, then I do a bulk rename of the old functions.

+1. My approach as well, effectively.

-Jim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120919/1e4fb0e4/attachment.html>