[llvm-commits] [llvm] r163885 - /llvm/trunk/lib/Transforms/Scalar/SROA.cpp

[Chandler Carruth]

This is a very new pass, and I don't have every version of GCC. I'm still
cleaning up a few warnings etc. Please hang in there for a little bit
longer, lots of fixes are in flight for me, but waiting on my builds to
finish to make sure they're correct.


On Fri, Sep 14, 2012 at 3:11 AM, Florian Weimer <fweimer at redhat.com> wrote:

> On 09/14/2012 12:09 PM, NAKAMURA Takumi wrote:
>
>> 2012/9/14 Florian Weimer <fweimer at redhat.com>:
>>
>>> On 09/14/2012 11:55 AM, NAKAMURA Takumi wrote:
>>>
>>>  -  void dump(const_iterator I) const LLVM_ATTRIBUTE_NOINLINE
>>>> LLVM_ATTRIBUTE_USED;
>>>> -  void dump() const LLVM_ATTRIBUTE_NOINLINE LLVM_ATTRIBUTE_USED;
>>>> +  void dump(const_iterator I) LLVM_ATTRIBUTE_NOINLINE
>>>> LLVM_ATTRIBUTE_USED
>>>> const;
>>>> +  void dump() LLVM_ATTRIBUTE_NOINLINE LLVM_ATTRIBUTE_USED const;
>>>>
>>>
>>>
>>> This breaks compilation with GCC 4.7.  I don't think GCC supports
>>> multiple
>>> __attribute__s per declaration.
>>>
>>
>> Florian, I believe r163886 could appease gcc.
>>
>
> Indeed it does, thanks.
>
> FYI, GCC reports two warnings, not sure if they are appropriate:
>
> ../lib/Transforms/Scalar/SROA.**cpp: In member function ‘bool
> {anonymous}::**AllocaPartitionRewriter::**visitMemTransferInst(llvm::**
> MemTransferInst&)’:
> ../lib/Transforms/Scalar/SROA.**cpp:1901:16: warning: unused variable
> ‘OrigBegin’ [-Wunused-variable]
> ../lib/Transforms/Scalar/SROA.**cpp: In member function ‘bool
> {anonymous}::**AllocaPartitionRewriter::**visitIntrinsicInst(llvm::**
> IntrinsicInst&)’:
> ../lib/Transforms/Scalar/SROA.**cpp:1997:12: warning: variable ‘New’ set
> but not used [-Wunused-but-set-variable]
>
>
> --
> Florian Weimer / Red Hat Product Security Team
> ______________________________**_________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120914/3888b6ea/attachment.html>