[llvm-commits] [llvm] r163885 - /llvm/trunk/lib/Transforms/Scalar/SROA.cpp

[Florian Weimer]

On 09/14/2012 12:09 PM, NAKAMURA Takumi wrote:
> 2012/9/14 Florian Weimer <fweimer at redhat.com>:
>> On 09/14/2012 11:55 AM, NAKAMURA Takumi wrote:
>>
>>> -  void dump(const_iterator I) const LLVM_ATTRIBUTE_NOINLINE
>>> LLVM_ATTRIBUTE_USED;
>>> -  void dump() const LLVM_ATTRIBUTE_NOINLINE LLVM_ATTRIBUTE_USED;
>>> +  void dump(const_iterator I) LLVM_ATTRIBUTE_NOINLINE LLVM_ATTRIBUTE_USED
>>> const;
>>> +  void dump() LLVM_ATTRIBUTE_NOINLINE LLVM_ATTRIBUTE_USED const;
>>
>>
>> This breaks compilation with GCC 4.7.  I don't think GCC supports multiple
>> __attribute__s per declaration.
>
> Florian, I believe r163886 could appease gcc.

Indeed it does, thanks.

FYI, GCC reports two warnings, not sure if they are appropriate:

../lib/Transforms/Scalar/SROA.cpp: In member function ‘bool 
{anonymous}::AllocaPartitionRewriter::visitMemTransferInst(llvm::MemTransferInst&)’:
../lib/Transforms/Scalar/SROA.cpp:1901:16: warning: unused variable 
‘OrigBegin’ [-Wunused-variable]
../lib/Transforms/Scalar/SROA.cpp: In member function ‘bool 
{anonymous}::AllocaPartitionRewriter::visitIntrinsicInst(llvm::IntrinsicInst&)’:
../lib/Transforms/Scalar/SROA.cpp:1997:12: warning: variable ‘New’ set 
but not used [-Wunused-but-set-variable]

-- 
Florian Weimer / Red Hat Product Security Team