[llvm-commits] [compiler-rt] r163414 - /compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc

[Chandler Carruth]

On Fri, Sep 7, 2012 at 4:21 PM, Daniel Dunbar <daniel at zuster.org> wrote:

> FWIW, I ran this by the ASAN guys before commit.
>
> On Friday, September 7, 2012, Chandler Carruth wrote:
>
>> On Fri, Sep 7, 2012 at 3:57 PM, Daniel Dunbar <daniel at zuster.org> wrote:
>>
>>> Author: ddunbar
>>> Date: Fri Sep  7 14:57:32 2012
>>> New Revision: 163414
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=163414&view=rev
>>> Log:
>>> [asan] Use a relative include path instead of requiring build system
>>> involvement.
>>>
>>
>> Instead of just making this change, how about comment on the change that
>> introduced the problem? You don't have access to all of the build systems
>> involved in this project, nor all of the scenarios in which this code is
>> built. This change doesn't actually work in all of them, which is why we
>> used the build system in the first place.
>>
>
> What is the build system where this doesn't work?
>

In some cases we re-locate some files from within ASan to other locations,
and thus the relative paths don't always match. I'm particularly concerned
about asan vs. sanitizer_common here though... So this particular case
(just a subdirectory of asan itself) is probably fine. Sorry for jumping
the gun, I was really thinking of the sanitizer_common headers.


> What is the actual problem you're trying to solve here? The CMake build
>> seems to work fine?
>>
>
> I think it is cleaner to have the relative include paths be obvious, and I
> felt this was more idiomatic with the rest of LLVM. I'll change it back to
> the other way if you have a strong preference.
>
>  - Daniel
>
>
>>
>>>
>>> Modified:
>>>     compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc
>>>
>>> Modified: compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc?rev=163414&r1=163413&r2=163414&view=diff
>>>
>>> ==============================================================================
>>> --- compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc
>>> (original)
>>> +++ compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc Fri
>>> Sep  7 14:57:32 2012
>>> @@ -14,8 +14,8 @@
>>>
>>>  #if defined(__APPLE__)
>>>
>>> -#include "asan_interceptors.h"
>>> -#include "asan_intercepted_functions.h"
>>> +#include "../asan_interceptors.h"
>>> +#include "../asan_intercepted_functions.h"
>>>
>>>  namespace __asan {
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120907/91a647df/attachment.html>