<div class="gmail_extra"><div class="gmail_quote">On Fri, Sep 7, 2012 at 4:21 PM, Daniel Dunbar <span dir="ltr"><<a href="mailto:daniel@zuster.org" target="_blank" class="cremed">daniel@zuster.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">FWIW, I ran this by the ASAN guys before commit.<div><div class="im"><br>On Friday, September 7, 2012, Chandler Carruth  wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra">
<div class="gmail_quote">On Fri, Sep 7, 2012 at 3:57 PM, Daniel Dunbar <span dir="ltr"><<a class="cremed">daniel@zuster.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ddunbar<br>
Date: Fri Sep  7 14:57:32 2012<br>
New Revision: 163414<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=163414&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=163414&view=rev</a><br>
Log:<br>
[asan] Use a relative include path instead of requiring build system involvement.<br></blockquote><div><br></div><div>Instead of just making this change, how about comment on the change that introduced the problem? You don't have access to all of the build systems involved in this project, nor all of the scenarios in which this code is built. This change doesn't actually work in all of them, which is why we used the build system in the first place.</div>

</div></div></blockquote><div><br></div></div><div>What is the build system where this doesn't work?</div></div></blockquote><div><br></div><div>In some cases we re-locate some files from within ASan to other locations, and thus the relative paths don't always match. I'm particularly concerned about asan vs. sanitizer_common here though... So this particular case (just a subdirectory of asan itself) is probably fine. Sorry for jumping the gun, I was really thinking of the sanitizer_common headers.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="im"><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="gmail_extra"><div class="gmail_quote"><div>What is the actual problem you're trying to solve here? The CMake build seems to work fine?</div></div></div></blockquote><div><br></div></div><div>I think it is cleaner to have the relative include paths be obvious, and I felt this was more idiomatic with the rest of LLVM. I'll change it back to the other way if you have a strong preference.</div>
<span class="HOEnZb"><font color="#888888">
<div><br></div><div> - Daniel</div></font></span><div class="im"><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


<br>
Modified:<br>
    compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc<br>
<br>
Modified: compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc?rev=163414&r1=163413&r2=163414&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc?rev=163414&r1=163413&r2=163414&view=diff</a><br>



==============================================================================<br>
--- compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc (original)<br>
+++ compiler-rt/trunk/lib/asan/dynamic/asan_interceptors_dynamic.cc Fri Sep  7 14:57:32 2012<br>
@@ -14,8 +14,8 @@<br>
<br>
 #if defined(__APPLE__)<br>
<br>
-#include "asan_interceptors.h"<br>
-#include "asan_intercepted_functions.h"<br>
+#include "../asan_interceptors.h"<br>
+#include "../asan_intercepted_functions.h"<br>
<br>
 namespace __asan {<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div></div>
</blockquote></div><br></div>