[llvm-commits] [llvm] r163405 - /llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp

[Chandler Carruth]

On Fri, Sep 7, 2012 at 2:56 PM, Benjamin Kramer <benny.kra at googlemail.com>wrote:

> Author: d0k
> Date: Fri Sep  7 13:56:10 2012
> New Revision: 163405
>
> URL: http://llvm.org/viewvc/llvm-project?rev=163405&view=rev
> Log:
> Contrary to what the documentation says, .lcomm alignment on COFF is in
> bytes, not power of 2.
>

Test case?

Also, if this is contrary to documentation, can we fix the documentation?
Can we at least add comments here to explain why we are diverging from
documented behavior? ;]


>
> Modified:
>     llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp
>
> Modified: llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp?rev=163405&r1=163404&r2=163405&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp (original)
> +++ llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp Fri Sep  7 13:56:10 2012
> @@ -19,7 +19,7 @@
>
>  MCAsmInfoCOFF::MCAsmInfoCOFF() {
>    GlobalPrefix = "_";
> -  COMMDirectiveAlignmentIsInBytes = false;
> +  COMMDirectiveAlignmentIsInBytes = true;
>    LCOMMDirectiveSupportsAlignment = true;
>    HasDotTypeDotSizeDirective = false;
>    HasSingleParameterDotFile = false;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120907/6415cfb7/attachment.html>