<div class="gmail_extra"><div class="gmail_quote">On Fri, Sep 7, 2012 at 2:56 PM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank" class="cremed">benny.kra@googlemail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Fri Sep  7 13:56:10 2012<br>
New Revision: 163405<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=163405&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=163405&view=rev</a><br>
Log:<br>
Contrary to what the documentation says, .lcomm alignment on COFF is in bytes, not power of 2.<br></blockquote><div><br></div><div>Test case?</div><div><br></div><div>Also, if this is contrary to documentation, can we fix the documentation? Can we at least add comments here to explain why we are diverging from documented behavior? ;]</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp<br>
<br>
Modified: llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp?rev=163405&r1=163404&r2=163405&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp?rev=163405&r1=163404&r2=163405&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp Fri Sep  7 13:56:10 2012<br>
@@ -19,7 +19,7 @@<br>
<br>
 MCAsmInfoCOFF::MCAsmInfoCOFF() {<br>
   GlobalPrefix = "_";<br>
-  COMMDirectiveAlignmentIsInBytes = false;<br>
+  COMMDirectiveAlignmentIsInBytes = true;<br>
   LCOMMDirectiveSupportsAlignment = true;<br>
   HasDotTypeDotSizeDirective = false;<br>
   HasSingleParameterDotFile = false;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>