[llvm-commits] Mips assembler implementation patch

[Carl Norum]

Has there been any progress on the Mips assembler front since last week?  I'd love to see it get in "for real".  Vladimir's patch plus my addition of the mfc0 instruction is building and running fine on our targets here.  I don't have any other good plans for more exhaustive testing I'm afraid.

-- Carl


On Aug 31, 2012, at 8:24 AM, "Medic, Vladimir" <vmedic at mips.com> wrote:

> Hi Carl,
> thank you for your remarks and the patch. I have removed two lines that caused this warning and the new patch is attached to this email.
> Did anybody else had a chance to look at this?
> 
> Thanks
> 
> Vladimir
> From: Carl Norum [carl at lytro.com]
> Sent: Thursday, August 30, 2012 7:07 PM
> To: Medic, Vladimir
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] Mips assembler implementation patch
> 
> 
> Works great here - I needed to add "mfc0" for my project, so I've attached that patch-to-your-patch here.    This patch is my first attempt at doing anything in a tablegen file, so a good look by someone more experienced will be much appreciated!
> 
> I also get these two warnings when building with your patch:
> 
>> lib/Target/Mips/AsmParser/MipsAsmParser.cpp:407:13: warning: 
>>       unused variable 'MnemLower' [-Wunused-variable]
>>   StringRef MnemLower = Mnemonic.lower();
>>             ^
>> lib/Target/Mips/AsmParser/MipsAsmParser.cpp:597:9: warning: 
>>       unused variable 'E' [-Wunused-variable]
>>   SMLoc E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer()-1);
>>         ^
>> 2 warnings generated.
> 
> I didn't address those with the patch in my attachment, though.
> 
> -- Carl
> 
> 
> <MipsAssemblerImplemenation.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120907/4cb90487/attachment.html>