<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><base href="x-msg://198/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div><div>Has there been any progress on the Mips assembler front since last week? I'd love to see it get in "for real". Vladimir's patch plus my addition of the mfc0 instruction is building and running fine on our targets here. I don't have any other good plans for more exhaustive testing I'm afraid.</div><div><br></div><div>-- Carl</div><div><br></div><br><div><div>On Aug 31, 2012, at 8:24 AM, "Medic, Vladimir" <<a href="mailto:vmedic@mips.com">vmedic@mips.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div ocsi="0" fpstyle="1" style="font-family: 'Lucida Grande'; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; "><div style="direction: ltr; font-family: Tahoma; font-size: 10pt; ">Hi Carl,<br>thank you for your remarks and the patch. I have removed two lines that caused this warning and the new patch is attached to this email.<br>Did anybody else had a chance to look at this?<br><br>Thanks<br><br>Vladimir<br><div style="font-family: 'Times New Roman'; font-size: 16px; "><hr tabindex="-1"><div id="divRpF748014" style="direction: ltr; "><font face="Tahoma" size="2"><b>From:</b><span class="Apple-converted-space"> </span>Carl Norum [<a href="mailto:carl@lytro.com">carl@lytro.com</a>]<br><b>Sent:</b><span class="Apple-converted-space"> </span>Thursday, August 30, 2012 7:07 PM<br><b>To:</b><span class="Apple-converted-space"> </span>Medic, Vladimir<br><b>Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><b>Subject:</b><span class="Apple-converted-space"> </span>Re: [llvm-commits] Mips assembler implementation patch<br></font><br></div><div></div><div><div><br></div><div>Works great here - I needed to add "mfc0" for my project, so I've attached that patch-to-your-patch here. This patch is my first attempt at doing anything in a tablegen file, so a good look by someone more experienced will be much appreciated!</div><div><br></div><div>I also get these two warnings when building with your patch:</div><div><br></div><div><div></div></div><blockquote type="cite"><div>lib/Target/Mips/AsmParser/MipsAsmParser.cpp:407:13: warning: </div><div> unused variable 'MnemLower' [-Wunused-variable]</div><div> StringRef MnemLower = Mnemonic.lower();</div><div> ^</div><div>lib/Target/Mips/AsmParser/MipsAsmParser.cpp:597:9: warning: </div><div> unused variable 'E' [-Wunused-variable]</div><div> SMLoc E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer()-1);</div><div> ^</div><div>2 warnings generated.</div></blockquote><div><br></div><div>I didn't address those with the patch in my attachment, though.</div><div><br></div><div>-- Carl</div><div><br></div><div><br></div></div></div></div><span><MipsAssemblerImplemenation.patch></span></div></blockquote></div><br></body></html>