[llvm-commits] [PATCH] Improve vmov domain conversion (followup)

[James Molloy]

Hi Jakob,

Do you mean MachineOperandIteratorBase::analyzeVirtReg()?

I missed that (unsurprisingly I think; an iterator class seems an odd place to store such a function and Doxygen isn't clever about showing inherited members in subclasses).

I can relocate the code there instead and use a similar structure instead of enum bitmasks if you prefer?

> +  MachineBasicBlock *MBB = MI->getParent();
>
> What's the difference between MBB and 'this' in this MBB member function?

Nothing; it's me being dozy.

Cheers,

James

______________________________________
From: Jakob Stoklund Olesen [stoklund at 2pi.dk]
Sent: 06 September 2012 19:33
To: James Molloy
Cc: llvm-commits at cs.uiuc.edu; Tim Northover
Subject: Re: [PATCH] Improve vmov domain conversion (followup)

On Sep 6, 2012, at 8:04 AM, James Molloy <james.molloy at arm.com> wrote:

> Hi Jakob,
>
> Thanks for the comments - it's taken me a day or two to get it rewritten
> generically enough :)
>
> The attached patch takes on board all of your comments: it adds an
> "isRegisterLive" query function to MachineBasicBlock, and adds an
> "analyzePhysReg" function to MachineInstr.
>
> They seemed generic enough to lift into the appropriate classes.
>
> How does this look to you?

Please look at the existing MachineOperandIteratorBase::analyzePhysReg() function.

+  MachineBasicBlock *MBB = MI->getParent();

What's the difference between MBB and 'this' in this MBB member function?

/jakob



-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.