[llvm-commits] [PATCH] Improve vmov domain conversion (followup)

[Jakob Stoklund Olesen]

On Sep 6, 2012, at 8:04 AM, James Molloy <james.molloy at arm.com> wrote:

> Hi Jakob,
> 
> Thanks for the comments - it's taken me a day or two to get it rewritten
> generically enough :)
> 
> The attached patch takes on board all of your comments: it adds an
> "isRegisterLive" query function to MachineBasicBlock, and adds an
> "analyzePhysReg" function to MachineInstr.
> 
> They seemed generic enough to lift into the appropriate classes.
> 
> How does this look to you?

Please look at the existing MachineOperandIteratorBase::analyzePhysReg() function.

+  MachineBasicBlock *MBB = MI->getParent();

What's the difference between MBB and 'this' in this MBB member function?

/jakob