[llvm-commits] [PATCH] Review request: Allow assembly macro parameters and arguments delimited by spaces

PaX Team pageexec at freemail.hu
Thu Aug 30 14:41:15 PDT 2012


On 30 Aug 2012 at 16:25, Rafael EspĂ­ndola wrote:

> Sorry, I completely forgot to reply to this email. I was extracting
> bits from the patch because it is still very large, which make it a
> bit hard to read. I also think it is missing some tests. Can you
> please try to split it in
> 
> * Comments and string fixes that already make sense on the current code.
> * Macro nesting fixes.
> * Support for default argument values
> * Changing the lexing to support white spaces.
> 
> at least the last 3 should have tests in them.

to help you guys move this up to trunk after the recent commits,
i'm attaching my current version against r162943. note the change
in ParseMacroArguments where i had to accomodate GNU as in that it
does not accept empty/missing macro arguments unlike (apparently)
darwin's does.

-------------- next part --------------
The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any other MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.

   ---- File information -----------
     File:  macro-default-args.patch
     Date:  30 Aug 2012, 23:37
     Size:  11842 bytes.
     Type:  Unknown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: macro-default-args.patch
Type: application/octet-stream
Size: 11842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120830/3f72265d/attachment.obj>


More information about the llvm-commits mailing list