[llvm-commits] [PATCH] Review request: Allow assembly macro parameters and arguments delimited by spaces

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Aug 30 13:25:30 PDT 2012


On 29 August 2012 17:28, Zhang, Andy <andy.zhang at intel.com> wrote:
> Hi Rafael,
>
> I noticed you committed bits of the patch, thanks. Would you be able to review the rest of it? I can commit it if the patch is ok with you.

Sorry, I completely forgot to reply to this email. I was extracting
bits from the patch because it is still very large, which make it a
bit hard to read. I also think it is missing some tests. Can you
please try to split it in

* Comments and string fixes that already make sense on the current code.
* Macro nesting fixes.
* Support for default argument values
* Changing the lexing to support white spaces.

at least the last 3 should have tests in them.

> Thanks,
> Andy

Cheers,
Rafael



More information about the llvm-commits mailing list