[llvm-commits] [llvm] r162780 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Eric Christopher]

On Aug 28, 2012, at 4:42 PM, Michael Liao <michael.liao at intel.com> wrote:

> On Tue, 2012-08-28 at 16:34 -0700, Eric Christopher wrote:
>> Yeah, I just like magic numbers commented :)
> 
> Does the following change look ok?
> 
> Index: lib/Target/X86/X86ISelLowering.cpp
> ===================================================================
> --- lib/Target/X86/X86ISelLowering.cpp	(revision 162804)
> +++ lib/Target/X86/X86ISelLowering.cpp	(working copy)
> @@ -14128,7 +14128,7 @@
>       Opnds.push_back(I->getOperand(0));
>       Opnds.push_back(I->getOperand(1));
>       // Re-evaluate the number of nodes to be traversed.
> -      e += 2;
> +      e += 2; // 2 more nodes (LHS and RHS) are pushed.
>       continue;
>     }
> 

Sure :)

-eric