[llvm-commits] [llvm] r162780 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Michael Liao]

On Tue, 2012-08-28 at 16:34 -0700, Eric Christopher wrote:
> Yeah, I just like magic numbers commented :)

Does the following change look ok?

Index: lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- lib/Target/X86/X86ISelLowering.cpp	(revision 162804)
+++ lib/Target/X86/X86ISelLowering.cpp	(working copy)
@@ -14128,7 +14128,7 @@
       Opnds.push_back(I->getOperand(0));
       Opnds.push_back(I->getOperand(1));
       // Re-evaluate the number of nodes to be traversed.
-      e += 2;
+      e += 2; // 2 more nodes (LHS and RHS) are pushed.
       continue;
     }
 

> 
> -eric
> 
> On Aug 28, 2012, at 4:34 PM, Michael Liao <michael.liao at intel.com> wrote:
> 
> > The change doesn't change the functionality but just simplify the code.
> > 
> > Yours
> > - Michael
> > 
> > On Tue, 2012-08-28 at 16:26 -0700, Eric Christopher wrote:
> >> On Aug 28, 2012, at 12:20 PM, Michael Liao <michael.liao at intel.com> wrote:
> >> 
> >>> Author: hliao
> >>> Date: Tue Aug 28 14:20:29 2012
> >>> New Revision: 162780
> >>> 
> >>> URL: http://llvm.org/viewvc/llvm-project?rev=162780&view=rev
> >>> Log:
> >>> Explicitly update the number of nodes to be traversed
> >> 
> >> Testcase? and a better comment.
> >> 
> >> -eric
> > 
> > 
>