[llvm-commits] [PATCH] Mangle @s in assembler symbol names (bug 12555)

Nick Gasson nmgasson at gmail.com
Sat Aug 18 06:41:34 PDT 2012


Hi,

The attached patch changes the mangler so that it replaces @ symbols in
identifiers by default. This was causing problems with invalid assembler
names being generated (on x86) when LLVM identifiers contained @s - see
here:

http://llvm.org/bugs/show_bug.cgi?id=12555

I'm not sure why @ was explicitly excluded from isAcceptableChar as I
can't find an assembler that allows it in symbol names. However, I've
followed the existing pattern for periods and UTF-8 by allowing it to be
customised in MCAsmInfo.


Nick

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mangle-ats.patch
Type: text/x-patch
Size: 2816 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120818/bdfa2557/attachment.bin>


More information about the llvm-commits mailing list