[llvm-commits] [PATCH 2/4] Profile metadata: Profile loader

Alastair Murray alastairmurray42 at gmail.com
Sat Aug 18 06:37:43 PDT 2012


Hello all,

Please review the attached patch.

This is the second of four patches to support setting branch weight 
metadata by profiling.  It depends on the first patch.

There are also three binary profile data files attached that are used 
for testing, these should go in test/Analysis/Profiling.

This patch implements the profile loader which can load profile data 
generated by programs compiled with "-insert-edge-profiling".  It also 
provides tests and moves three function definitions out of ProfileInfo 
into the new profiling code.  The pass is invoked by 
"-profile-metadata-loader", but I believe that once ProfileInfo etc. is 
removed it should take over the "-profile-loader" switch that that 
currently uses.

The attached patch has been cleaned up a little from the version sent to 
llvm-dev last week, some class renaming, commenting etc.  It is largely 
the same in logical terms though.

It has been tested via the attached tests and by 
'-profile-metadata-loader -std-compile-opts' over test-suite (using the 
Makefile to come in patch #4).

Regards,
Alastair.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: weights_2_profiler_loader.patch
Type: text/x-patch
Size: 39092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120818/d752f904/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: load-branch-weights-ifs.ll.prof_data
Type: application/octet-stream
Size: 100 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120818/d752f904/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: load-branch-weights-loops.ll.prof_data
Type: application/octet-stream
Size: 132 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120818/d752f904/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: load-branch-weights-switches.ll.prof_data
Type: application/octet-stream
Size: 160 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120818/d752f904/attachment-0002.obj>


More information about the llvm-commits mailing list