[llvm-commits] Fix Bug 13574: Add more double float shrinking optimizations

[Weiming Zhao]

Thanks for pointing that out. I will add a check.


-----Original Message-----
From: Eli Friedman [mailto:eli.friedman at gmail.com] 
Sent: Wednesday, August 15, 2012 1:42 PM
To: Weiming Zhao
Cc: Stephen Canon; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] Fix Bug 13574: Add more double float shrinking
optimizations

On Wed, Aug 15, 2012 at 1:37 PM, Weiming Zhao <weimingz at codeaurora.org>
wrote:
> Hi Steve,
>
>
>
> Yes, it transforms (float)func((double) val) to funcf(v), which saves 
> 2 conversions and possibly cheaper math  function.

That isn't the same transformation that your patch does.
Specifically, the transformation in your patch doesn't check how result is
used (which is fine for floor, but not cos).

-Eli