[llvm-commits] Fix Bug 13574: Add more double float shrinking optimizations

Stephen Canon scanon at apple.com
Wed Aug 15 13:42:49 PDT 2012


On Aug 15, 2012, at 4:41 PM, Eli Friedman <eli.friedman at gmail.com> wrote:

> On Wed, Aug 15, 2012 at 1:37 PM, Weiming Zhao <weimingz at codeaurora.org> wrote:
>> Hi Steve,
>> 
>> 
>> 
>> Yes, it transforms (float)func((double) val) to funcf(v), which saves 2
>> conversions and possibly cheaper math  function.
> 
> That isn't the same transformation that your patch does.
> Specifically, the transformation in your patch doesn't check how
> result is used (which is fine for floor, but not cos).

Exactly.



More information about the llvm-commits mailing list