[llvm-commits] [PATCH] Add support for fast calling convention

[Renato Golin]

On 10 August 2012 12:25, Jush Lu <jush.msn at gmail.com> wrote:
> Hi all,
>
> As Renato's suggestion, I split the last patch into two patches.

It was actually Chad's suggestion, I just agreed with him... :D


> 'fast-isel-fastcc.patch' is for fix, and another is for clean up.

The clean-up is harmless, and should pose no problems. However, it
seems you ended up with two implementations of the same thing (sorry I
missed that in the first review).

AFAIK, fastcc in ARM is the same as AAPCS, so there is no point in
having two similar logics for both. The original implementation,
though, seemed to be wrong assuming "fastcc" (like CCC) should be
default to APCS, rather than AAPCS.

I think the best course of action is to common up the two
implementations (ie. leave the fall through as it is), by adding
yet-another test in the end (and on ABI check), taking (CC ==
CallingConv::Fast) into consideration.

And add the working version of the tests, for completeness.

-- 
cheers,
--renato

http://systemcall.org/