[llvm-commits] [PATCH] Add support for fast calling convention

[Jush Lu]

Hi all,

As Renato's suggestion, I split the last patch into two patches.
'fast-isel-fastcc.patch' is for fix, and another is for clean up.

I will commit them separately if approval, please review them, thanks.

Jush

On Fri, Aug 10, 2012 at 6:21 PM, Renato Golin <rengolin at systemcall.org>wrote:

> On 10 August 2012 04:49, Jush Lu <jush.msn at gmail.com> wrote:
> > This part doesn’t fix anything, it just simplifies if statements, no
> > functionality changes in this part.
>
> I think this is an even bigger reason to split the patch.
>
> The fix should be minimalistic and have all possible tests associated,
> to make it easier to roll-back, further analyse and to know what that
> patch was intended to fix in the first place, say, an year from now.
>
> It doesn't matter much if you want to submit the fix first or the
> clean up first. Clean-ups also generally don't need additional tests.
>
> --
> cheers,
> --renato
>
> http://systemcall.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120810/b2614c01/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fast-isel-fastcc.patch
Type: application/octet-stream
Size: 1586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120810/b2614c01/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fast-isel-simplify-if.patch
Type: application/octet-stream
Size: 1155 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120810/b2614c01/attachment-0001.obj>