[llvm-commits] [PATCH] Review request: Test case for indirect argument with X86FastISel

[Kaylor, Andrew]

Hi Evan,

I don't have any particular output that I want to test for.  From my perspective, if the test doesn't crash then it passed.

The motivation for the test is that in an earlier incarnation of the X86FastISel code, indirect function arguments caused an llvm_unreachable exception.  This test exercises the code path that led there.

I have attached a new patch that I think addresses your other comments.

Thanks,
Andy

From: Evan Cheng [mailto:evan.cheng at apple.com]
Sent: Monday, August 06, 2012 1:06 PM
To: Kaylor, Andrew
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Review request: Test case for indirect argument with X86FastISel

The RUN line doesn't specify target arch or triple. That's going to break some buildbots. Also, please significantly reduce the test to include only the functionality it is intended to test. Right now it includes main() and other parts that are not needed. You also don't have patterns that tell us what it is you are testing.

Evan

On Aug 3, 2012, at 10:20 AM, "Kaylor, Andrew" <andrew.kaylor at intel.com<mailto:andrew.kaylor at intel.com>> wrote:


Ping.

From: llvm-commits-bounces at cs.uiuc.edu<mailto:llvm-commits-bounces at cs.uiuc.edu> [mailto:llvm-commits-bounces at cs.uiuc.edu<mailto:commits-bounces at cs.uiuc.edu>] On Behalf Of Kaylor, Andrew
Sent: Friday, July 27, 2012 1:12 PM
To: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: [llvm-commits] [PATCH] Test case for indirect argument with X86FastISel

Hi everyone,

The attached patch adds an X86 CodeGen test for the case where an indirect argument is used while FastISel was enabled.  This is the test case for a patch I previously posted here:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120709/146224.html

which was committed in r16055.

I've only seen the indirect argument being generated on Windows, but the test will pass on other platforms without the indirect argument being generated.

-Andy

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120807/e6b639c7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: indirect-arg-test-2.patch
Type: application/octet-stream
Size: 4065 bytes
Desc: indirect-arg-test-2.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120807/e6b639c7/attachment.obj>