[llvm-commits] [compiler-rt] r161406 - in /compiler-rt/trunk/lib: asan/lit_tests/CMakeLists.txt asan/lit_tests/Unit/ asan/lit_tests/Unit/lit.cfg asan/lit_tests/Unit/lit.site.cfg.in asan/lit_tests/lit.site.cfg.in asan/tests/CMakeLists.txt lit.comm

[Chandler Carruth]

On Tue, Aug 7, 2012 at 2:31 AM, Alexey Samsonov <samsonov at google.com> wrote:

>
>
> On Tue, Aug 7, 2012 at 1:22 PM, Chandler Carruth <chandlerc at google.com>
>  wrote:
>
> On Tue, Aug 7, 2012 at 1:59 AM, Alexey Samsonov <samsonov at google.com>
>>  wrote:
>>
>>> Author: samsonov
>>> Date: Tue Aug  7 03:59:15 2012
>>> New Revision: 161406
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=161406&view=rev
>>> Log:
>>> [ASan] Add support for running unit tests by lit (as a part of 'make
>>> check-asan' command)
>>>
>>> Added:
>>>     compiler-rt/trunk/lib/asan/lit_tests/Unit/
>>>     compiler-rt/trunk/lib/asan/lit_tests/Unit/lit.cfg
>>>     compiler-rt/trunk/lib/asan/lit_tests/Unit/lit.site.cfg.in
>>>     compiler-rt/trunk/lib/lit.common.unit.cfg
>>> Modified:
>>>     compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt
>>>     compiler-rt/trunk/lib/asan/lit_tests/lit.site.cfg.in
>>>     compiler-rt/trunk/lib/asan/tests/CMakeLists.txt
>>>
>>> Modified: compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt?rev=161406&r1=161405&r2=161406&view=diff
>>>
>>> ==============================================================================
>>> --- compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt (original)
>>> +++ compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt Tue Aug  7
>>> 03:59:15 2012
>>> @@ -1,15 +1,39 @@
>>> +set(ASAN_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/..)
>>> +set(ASAN_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/..)
>>> +
>>>  configure_lit_site_cfg(
>>>    ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
>>>    ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
>>>    )
>>>
>>> +configure_lit_site_cfg(
>>> +  ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.in
>>> +  ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg
>>> +  )
>>> +
>>>  set(ASAN_TEST_DEPS
>>> -  clang clang-headers FileCheck count not
>>>    clang-rt.asan-x86_64 clang-rt.asan-i386
>>>
>>
>> I don't think you even need the runtime libraries... AsanUnitTests should
>> bring everything it needs?
>>
>
> Only if LLVM_INCLUDE_TESTS is set.
>

Sorry, I was trying to suggest sinking the libraries down to where you add
clang, clang-headers, etc... Not removing them completely.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120807/5b17cfd8/attachment.html>