On Tue, Aug 7, 2012 at 2:31 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank" class="cremed">samsonov@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br><div class="gmail_quote">On Tue, Aug 7, 2012 at 1:22 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank" class="cremed">chandlerc@google.com</a>></span> wrote:<div>
<div class="h5"><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On Tue, Aug 7, 2012 at 1:59 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank" class="cremed">samsonov@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Author: samsonov<br>Date: Tue Aug  7 03:59:15 2012<br>New Revision: 161406<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=161406&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=161406&view=rev</a><br>

Log:<br>[ASan] Add support for running unit tests by lit (as a part of 'make check-asan' command)<br><br>Added:<br>    compiler-rt/trunk/lib/asan/lit_tests/Unit/<br>    compiler-rt/trunk/lib/asan/lit_tests/Unit/lit.cfg<br>

    compiler-rt/trunk/lib/asan/lit_tests/Unit/<a href="http://lit.site.cfg.in/" target="_blank" class="cremed">lit.site.cfg.in</a><br>    compiler-rt/trunk/lib/lit.common.unit.cfg<br>Modified:<br>    compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt<br>

    compiler-rt/trunk/lib/asan/lit_tests/<a href="http://lit.site.cfg.in/" target="_blank" class="cremed">lit.site.cfg.in</a><br>    compiler-rt/trunk/lib/asan/tests/CMakeLists.txt<br><br>Modified: compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt<br>

URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt?rev=161406&r1=161405&r2=161406&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt?rev=161406&r1=161405&r2=161406&view=diff</a><br>

==============================================================================<br>--- compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt (original)<br>+++ compiler-rt/trunk/lib/asan/lit_tests/CMakeLists.txt Tue Aug  7 03:59:15 2012<br>

@@ -1,15 +1,39 @@<br>+set(ASAN_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/..)<br>+set(ASAN_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/..)<br>+<br> configure_lit_site_cfg(<br>   ${CMAKE_CURRENT_SOURCE_DIR}/<a href="http://lit.site.cfg.in/" target="_blank" class="cremed">lit.site.cfg.in</a><br>

   ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg<br>   )<br><br>+configure_lit_site_cfg(<br>+  ${CMAKE_CURRENT_SOURCE_DIR}/Unit/<a href="http://lit.site.cfg.in/" target="_blank" class="cremed">lit.site.cfg.in</a><br>+  ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg<br>

+  )<br>+<br> set(ASAN_TEST_DEPS<br>-  clang clang-headers FileCheck count not<br>   clang-rt.asan-x86_64 clang-rt.asan-i386<br></blockquote><div><br></div><div>I don't think you even need the runtime libraries... AsanUnitTests should bring everything it needs?</div>

</div></div></blockquote><div><br></div></div></div><div>Only if LLVM_INCLUDE_TESTS is set.</div></div></blockquote><div><br></div><div>Sorry, I was trying to suggest sinking the libraries down to where you add clang, clang-headers, etc... Not removing them completely.</div>
</div></div>