[llvm-commits] [llvm] r160454 - in /llvm/trunk: lib/Target/X86/X86InstrArithmetic.td lib/Target/X86/X86InstrInfo.cpp test/CodeGen/X86/jump_sign.ll

[Chris Lattner]

On Jul 25, 2012, at 8:43 AM, Manman Ren wrote:

>> 
>> Hi Manman,
>> 
>>> +/// isDefConvertible - check whether the definition can be converted
>>> +/// to remove a comparison against zero.
>>> +inline static bool isDefConvertible(MachineInstr *MI) {
>> 
>> These big hand-written table of predicates are kind of sad, because it entails behavior that isn't surfaced in the .td file.  Would this be reasonable to represent with a bit in the "TSFlags" field?
>> 
> 
> I feel like this is not general enough to deserve a space in TSFlags :)
> I will see whether we can simplify this with existing information in TSFlags.

Ok!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120726/2e9810c3/attachment.html>