<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 25, 2012, at 8:43 AM, Manman Ren wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><blockquote type="cite"><br class="Apple-interchange-newline">Hi Manman,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">+/// isDefConvertible - check whether the definition can be converted<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">+/// to remove a comparison against zero.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">+inline static bool isDefConvertible(MachineInstr *MI) {<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">These big hand-written table of predicates are kind of sad, because it entails behavior that isn't surfaced in the .td file. Would this be reasonable to represent with a bit in the "TSFlags" field?<br></blockquote><blockquote type="cite"><br></blockquote><br>I feel like this is not general enough to deserve a space in TSFlags :)<br>I will see whether we can simplify this with existing information in TSFlags.</div></span></blockquote></div><br><div>Ok!</div></body></html>